Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove @typescript-eslint/lines-between-class-members #982

Closed
monfera opened this issue Jan 18, 2021 · 0 comments · Fixed by #978
Closed

Remove @typescript-eslint/lines-between-class-members #982

monfera opened this issue Jan 18, 2021 · 0 comments · Fixed by #978
Labels
chore enhancement New feature or request

Comments

@monfera
Copy link
Contributor

monfera commented Jan 18, 2021

Add the required rule prefix @typescript-eslint/ before the rule name for it to actually have the intended effect.

Let's deactivate @typescript-eslint/lines-between-class-members (Expected blank line between class members) which afaict was added as part of a large set of rules and wasn't discussed specifically.

Very frequently, class members have a number of properties. They generally take up a single line. Forcing developers to add a line, automatically or not, yields objectionable, verbose code. It adds separation and heft where it often shouldn't. While beauty is in the eye of the beholder. as it's a subjective matter, let's retain the freedom - anyone can still add a line manually, but if the rule is active, it's impossible not to have a filler line.

Also, this is not a proposal to prohibit line drops.

For what it's worth, I also don't think it'd be good to enforce a line drop between adjacent top-level definitions in a file. For example, it'd enforce short constant assignments and maybe imports to be separated by a line drop

@monfera monfera added enhancement New feature or request chore labels Jan 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
chore enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant