Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[small multiples] Render axis on every panel #891

Open
Tracked by #2320
markov00 opened this issue Nov 5, 2020 · 0 comments
Open
Tracked by #2320

[small multiples] Render axis on every panel #891

markov00 opened this issue Nov 5, 2020 · 0 comments
Assignees
Labels
:axis Axis related issue enhancement New feature or request :small multiples Small multiples/trellising related issues

Comments

@markov00
Copy link
Member

markov00 commented Nov 5, 2020

Describe the solution you'd like
We should let the user configure the ability to show axes on every panel.
This should be in some degree configurable:

  • when showing only the main set of axes at the edges of the small multiples grid we should also display by default just the vertical and horizontal axis line
  • showing the axis labels on every panel as an option (reconsidering the current padding percentage option to accommodate longer text in the inner panels of the grid)

One main change needs to be applied:

  • refactor the axes geometry generator to correctly compute the anchor point of each axis (see also src/chart_types/xy_chart/state/selectors/compute_per_panel_axes_geoms.ts that currently render axis only on the first column and the last row)
@markov00 markov00 added enhancement New feature or request :small multiples Small multiples/trellising related issues :axis Axis related issue labels Nov 5, 2020
@markov00 markov00 self-assigned this Nov 11, 2020
@nickofthyme nickofthyme assigned nickofthyme and unassigned markov00 Jan 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
:axis Axis related issue enhancement New feature or request :small multiples Small multiples/trellising related issues
Projects
None yet
Development

No branches or pull requests

2 participants