Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow specifying axis domain padding as pixel #1144

Closed
3 tasks done
flash1293 opened this issue May 4, 2021 · 1 comment · Fixed by #1145
Closed
3 tasks done

Allow specifying axis domain padding as pixel #1144

flash1293 opened this issue May 4, 2021 · 1 comment · Fixed by #1145
Assignees
Labels
enhancement New feature or request released Issue released publicly

Comments

@flash1293
Copy link

Is your feature request related to a problem? Please describe.
Axis domain padding can be specified as percentage or total value related to the scale itself. However as this setting is often used for aesthetics, it would be useful to specify it as a pixel value.

Describe the solution you'd like
elastic-charts should take a setting like this:

{ padding:  '10px' }

Then it does the calculation of values to pixels and applies the appropriate padding

Describe alternatives you've considered
Theoretically the consumer could do this calculation, but it's cumbersome because the height of the chart has to be tracked to do so.

Additional context
This came up because the comment of the padding property actually specifies it can be a pixel value which is not the case

Checklist

Delete any items that are not applicable to this feature request.

  • this request is checked against already exist requests
  • every related Kibana issue is listed under Kibana Cross Issues list
  • kibana cross issue tag is associated to the issue if any kibana cross issue is present
@flash1293 flash1293 added the enhancement New feature or request label May 4, 2021
@nickofthyme nickofthyme self-assigned this May 4, 2021
@nickofthyme
Copy link
Collaborator

🎉 This issue has been resolved in version 30.0.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickofthyme nickofthyme added the released Issue released publicly label Jun 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request released Issue released publicly
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants