Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EDOT-Collector Docker Images #6764

Open
strawgate opened this issue Feb 7, 2025 · 4 comments
Open

EDOT-Collector Docker Images #6764

strawgate opened this issue Feb 7, 2025 · 4 comments
Assignees
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team

Comments

@strawgate
Copy link
Contributor

strawgate commented Feb 7, 2025

As a follow-on to #6542

Implementing this for the elastic-agent images is a breaking change, but we also want to introduce new edot-collector images for Elastic Agent.

For Elastic Agent we want there to be two docker images: elastic-agent which includes all components and elastic-agent-slim, which would be a container built with only agentbeat, osqueryd, and pf-host-agent.

For EDOT Collector, we want there to be one docker image: edot-collector which includes only Agentbeat and osqueryd. Ideally this would be the same image as elastic-agent-slim, simply aliased to edot-collector.

As a workaround to enable availability of the edot-collector image starting with 9.0, without making a breaking change later, we could base our edot-collector image on the existing elastic-agent image, and simply delete the extra components from the image. The addition/removal of the components would still occupy space in the image as they would be done in separate layers, but the binaries would be unavailable for a customer to leverage.

When we are ready to take on work to produce the slim image from scratch we will be able to swap it in without a breaking change for users.

@cmacknz
Copy link
Member

cmacknz commented Feb 7, 2025

I assume we want the entrypoint to be different in the edot image?

We may as well introduce elastic-agent-slim at the same time, and just have the base images set up the way we want from the beginning. It won't cost us much more in terms of effort.

P.S. every additional docker image we add needs another trip through our container and kubernetes smoke tests in CI so there is an overhead to adding images from a development perspective.

@strawgate
Copy link
Contributor Author

I assume we want the entrypoint to be different in the edot image?

I think defaulting to OTel mode is probably the big change here. Once hybrid agent is available, it'll all be otel mode anyway.

@cmacknz cmacknz added the Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team label Feb 10, 2025
@elasticmachine
Copy link
Contributor

Pinging @elastic/elastic-agent-control-plane (Team:Elastic-Agent-Control-Plane)

@jlind23
Copy link
Contributor

jlind23 commented Feb 11, 2025

For now adding this to our todo list for next sprint in order to potentially ship it in 9.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Control-Plane Label for the Agent Control Plane team
Projects
None yet
Development

No branches or pull requests

5 participants