-
Notifications
You must be signed in to change notification settings - Fork 418
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Maxmind vs Logstash's GeoIP Filter #1217
Comments
Thanks for opening this issue @yaauie. Choropleth mapping in the Elastic Maps product could also benefit from some of these fields in ECS. We already support US postal codes and adding support for timezones and continents should also be possible. cc @elastic/kibana-gis |
++ to adding The more I explore it, the more I also can see adding The motivation for |
I'm -1 to putting |
Thanks for the feedback, @yaauie. If we opt to not add If we have an agreement around adding the three new fields to |
Perfect. I appreciate the guidance.
We already have a ++ to:
|
Yes, |
Summary
The Logstash GeoIP filter uses the a maxminddb-formatted database (that may or may not be provided by Maxmind) to populate a number of fields to enrich an event based on an IP address. As presently implemented in the Logstash filter, all fields need to be sub-fields of a single
target
(e.g, withtarget => client
, we would haveclient.geo.*
,client.as.*
, etc.).Motivation:
Clearly define destinations for all GeoIP Filter fields as a sub-field of a single target, so that users can enable ECS Compatibility Mode without losing metadata that they currently rely on.
Specifically, we have six fields that do not have direct analogues in ECS:
timezone
: the IANA name of the timezone e.g., America/New_Yorkpostal_code
: a string postal code, length varies by countrycontinent_code
: "A two character continent code like "NA" (North America) or "OC" (Oceania)"organization
: the name of the business or ISP associated with an address, reportedly available for ~40% of lookups.isp
: the name of the ISPdma_code
: us-only code representing Designated Market Area (~metro area)Detailed Design:
geo.timezone
(IANA name, presently up to 30 characters, e.g.,America/Argentina/Buenos_Aires
),geo.postal_code
(freeform but relatively space limited, regulated by each country; see wikipedia),geo.continent_code
(docs defineAF
,AN
,AS
,EU
,NA
,OC
, andSA
)target
that is the parent of the relatedgeo
andas
fields.mmdb
sub-key? e.g,${target}.mmdb.organization
mmdb
being used may or may not be provided by Maxmind, I'd like to avoid explicitly using "maxmind" in the key namedma_code
, while provided in mmdb, is a US-only Nielsen Ratings construct and may not be adequately described with ammdb
prefix.Related: logstash-plugins/logstash-filter-geoip#163
The text was updated successfully, but these errors were encountered: