Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Version in APM status does not get populated (no reconciliation) #3533

Closed
sebgl opened this issue Jul 27, 2020 · 0 comments · Fixed by #3534
Closed

Version in APM status does not get populated (no reconciliation) #3533

sebgl opened this issue Jul 27, 2020 · 0 comments · Fixed by #3534
Assignees
Labels
>bug Something isn't working

Comments

@sebgl
Copy link
Contributor

sebgl commented Jul 27, 2020

I was playing with E2E tests to cover strict version upgrades, and noticed in some cases the APM status.version field never gets populated, because no reconciliation happened.

I think this is simply because we did not catch the version change in the last updated Pod (no reconciliation triggered).

2 options to fix this:

  1. watch APMServer Pods, to reconcile on any change
  2. compute the version status field based on the deployment resource (instead of checking that all Pods run 7.8.0, check that the deployment resource specifies 7.8.0, that generation matches observedGeneration, and that all replicas are ready... it's a bit trickier)

I think 1) is simpler to implement, and we already watch all Pods as part of the ES controller anyway.

I suspect it is also required for any controller that manipulates Pod-level information. Which is true, besides status.version, for:

  • changing the deployment strategy for Kibana version upgrades
  • calling the read-only endpoint for Enterprise Search version upgrade
@sebgl sebgl added the >bug Something isn't working label Jul 27, 2020
@sebgl sebgl self-assigned this Jul 27, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant