Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wait until Pod TLS certificate are correct in the prepare-fs init container #2832

Closed
sebgl opened this issue Apr 8, 2020 · 1 comment
Closed
Labels
>bug Something isn't working discuss We need to figure this out

Comments

@sebgl
Copy link
Contributor

sebgl commented Apr 8, 2020

Related to #2823.

bug in Elasticsearch leads to Elasticsearch presenting an outdated certificate with the wrong IP address during and after rolling upgrades.

To mitigate this, we can improve the existing prepare-fs init container to not only wait for certificates to be present on disk, but also to ensure those certificates have the correct IP address, before we move on with the Elasticsearch container.

openssl is not present in the Elasticsearch Docker image so we cannot easily inspect the certificate content. Instead we may need to clearly identify Pods IP addresses in the certs secret content. For example, by adding new files that associate a Pod name to a Pod IP address. In the script, we would wait until the IP address presented in the secret files matches the $POD_IP environment variable.

We must make sure this new way of doing things does not break existing clusters which rely on the existing certificate files, named from the pod name.

#2830 proposes an other alternative where we would rely on Pod DNS names instead of IP addresses, which would make this issue irrelevant.

@sebgl sebgl added the discuss We need to figure this out label Apr 8, 2020
@botelastic botelastic bot added the triage label Apr 8, 2020
@david-kow david-kow added the >bug Something isn't working label Apr 27, 2020
@botelastic botelastic bot removed the triage label Apr 27, 2020
@pebrc
Copy link
Collaborator

pebrc commented Mar 5, 2023

The underlying issue in Elasticsearch has been addressed in elastic/elasticsearch#54999 I am closing this as well.

@pebrc pebrc closed this as completed Mar 5, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>bug Something isn't working discuss We need to figure this out
Projects
None yet
Development

No branches or pull requests

3 participants