Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve PDB cluster checks #1774

Open
sebgl opened this issue Sep 23, 2019 · 0 comments
Open

Improve PDB cluster checks #1774

sebgl opened this issue Sep 23, 2019 · 0 comments
Labels
>enhancement Enhancement of existing functionality

Comments

@sebgl
Copy link
Contributor

sebgl commented Sep 23, 2019

When updating the default PDB MinAvailable value, we look at:

  • cluster health
  • number of master nodes
  • number of data nodes

It gives a good best-effort sense on whether 1 pod can be disrupted or not, but it has some flaws:

  1. The cluster health information we use here is out-of-date, and comes from the last observed cluster health from Elasticsearch. We may see a yellow cluster as green, temporarily.

  2. Even though Pods are reported Ready, they might not be part of the cluster yet. Which could lead us to allow one pod to be disrupted (7/7 Pods ready) even if only half of them are actually part of the cluster. We could check if all nodes belong to the cluster (_cat/nodes) before allowing one to be disrupted.

@sebgl sebgl added the >enhancement Enhancement of existing functionality label Sep 23, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
>enhancement Enhancement of existing functionality
Projects
None yet
Development

No branches or pull requests

1 participant