Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more flexible when comparing node roles labels for PVC reuse #1159

Closed
sebgl opened this issue Jun 27, 2019 · 1 comment
Closed

Be more flexible when comparing node roles labels for PVC reuse #1159

sebgl opened this issue Jun 27, 2019 · 1 comment
Labels
discuss We need to figure this out

Comments

@sebgl
Copy link
Contributor

sebgl commented Jun 27, 2019

We currently require a strict node role mapping while attempting to reuse PVCs.

This helps us make sure a master node does not get assigned a data volume, and the other way around.

However consider the following case:

  • 3 master-data nodes
  • the user enables the ML role on all nodes

Currently we'll not reuse PVCs for those 3 ML nodes, and go through data migration. But we could reuse PVCs. Should we also reuse PVCs the other way around (data-ML become data only)?

@sebgl sebgl added the discuss We need to figure this out label Jun 27, 2019
@sebgl
Copy link
Contributor Author

sebgl commented Jul 30, 2019

We decided to rely on one StatefulSet per NodeSpec in the Elasticsearch CRD.
PVC reuse is now limited to NodeSpecs with the same name. It's basically up to the user to control PVC reuse: keep the nodeSpec name if you want to reuse PVCs, use another name if you want fresh new volumes.

@sebgl sebgl closed this as completed Jul 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
discuss We need to figure this out
Projects
None yet
Development

No branches or pull requests

1 participant