Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[meta] Deprecate winlogbeat in favor of filebeat winlog input. #40074

Open
1 of 5 tasks
marc-gr opened this issue Jul 2, 2024 · 10 comments
Open
1 of 5 tasks

[meta] Deprecate winlogbeat in favor of filebeat winlog input. #40074

marc-gr opened this issue Jul 2, 2024 · 10 comments
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Windows Platform Windows Platform Team in Security Solution

Comments

@marc-gr
Copy link
Contributor

marc-gr commented Jul 2, 2024

Some time ago the winlog input was added to filebeat so it could be used by the elastic agent.

The functionality is basically on par with winlogbeat, which makes us maintain both implementations.

Would be nice to discuss the possibility to deprecate winlogbeat in the following releases, making the preferred choice filebeat winlog input or elastic agent integrations to consume windows events. This way we could prepare users targetting winlogbeat removal for a future 9.0 version.

TODO:

  • Convert the Winlogbeat modules and the routing pipeline into a Filebeat module
  • document the winlog input
  • update all detection rules for windows event logs to search filebeat-* indices
  • review Kibana for any special handling of event logs that depends on winlogbeat-* or perhaps agent.type: winlogbeat
  • mark winlogbeat as deprecated and provide guidance to migrate
@marc-gr marc-gr added discuss Issue needs further discussion. Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Windows Platform Windows Platform Team in Security Solution labels Jul 2, 2024
@elasticmachine
Copy link
Collaborator

Pinging @elastic/elastic-agent-data-plane (Team:Elastic-Agent-Data-Plane)

@elasticmachine
Copy link
Collaborator

Pinging @elastic/sec-windows-platform (Team:Security-Windows Platform)

@andrewkroh
Copy link
Member

Some things that would be needed to make Filebeat equivalent are

  • convert the Winlogbeat modules and the routing pipeline into a Filebeat module
  • document the winlog input
  • update all detection rules for windows event logs to search filebeat-* indices
  • review Kibana for any special handling of event logs that depends on winlogbeat-* or perhaps agent.type: winlogbeat

One thing to consider is the impact of OpenTelemetry, if we decided to start supporting the OTel collector to ingest windows event logs, then I think we would want Winlogbeat users to migrate to that. I would want to avoid having users migrate from Winlogbeat->Filebeat and then Filebeat->OTel if those two changes are possible within a short time window. So it might worth asking what it would take to make Windows event log collection/processing portable to OTel 🤔.

@marc-gr
Copy link
Contributor Author

marc-gr commented Jul 2, 2024

Would the otel usecase also impact the current winlog integrations?

@pierrehilbert
Copy link
Collaborator

@leehinman could you have a look here please?

@strawgate
Copy link
Contributor

@andrewkroh and I will be chatting today but I think we should definitely chat about using the OTel input

@marc-gr
Copy link
Contributor Author

marc-gr commented Jul 11, 2024

After some conversations it seems the OTel collector should not impact the progress of this. Will convert this into a meta issue. Please feel free to chime in if there are still unclear things.

@marc-gr marc-gr changed the title [discuss] Deprecate winlogbeat in favor of filebeat winlog input. [meta] Deprecate winlogbeat in favor of filebeat winlog input. Jul 11, 2024
@marc-gr marc-gr removed the discuss Issue needs further discussion. label Jul 11, 2024
@nicpenning
Copy link
Contributor

nicpenning commented Aug 28, 2024

👀 woohoo!

This is great. I have had concerns with two separate products doing nearly the same function and seeing missed bugs/issues on one or the other.

After this, perhaps we can talk about the name "filebeat" hahaha 😆

@andrewkroh
Copy link
Member

I have had concerns with two separate products doing nearly the same function and seeing missed bugs/issues

I am concerned with the change actually making this worse. While we may deprecate one, there will still be multiple copies of ingest pipeline logic floating around. I think we need to discuss this more, @marc-gr. I want to avoid yet another clone/fork of the pipelines.

@marc-gr
Copy link
Contributor Author

marc-gr commented Aug 30, 2024

I have had concerns with two separate products doing nearly the same function and seeing missed bugs/issues

I am concerned with the change actually making this worse. While we may deprecate one, there will still be multiple copies of ingest pipeline logic floating around. I think we need to discuss this more, @marc-gr. I want to avoid yet another clone/fork of the pipelines.

I'll hold migrating the modules for now then

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Elastic-Agent-Data-Plane Label for the Agent Data Plane team Team:Security-Windows Platform Windows Platform Team in Security Solution
Projects
None yet
Development

No branches or pull requests

6 participants