Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Filebeat] Add sophos XG log samples containing new field names #31038

Closed
wants to merge 2 commits into from

Conversation

piellick
Copy link

Here is a bunch of firewall logs from sophos.

Type of change

Enhancement

What does this PR do?

Update firewall logs from sophos XG for testing.

Why is it important?

Related to PR #28932 --> [elastic/beats] [Filebeat] Sophos Module - support for changed field names

Here is a bunch of firewall logs from sophos.
@piellick piellick requested a review from a team as a code owner March 29, 2022 10:06
@botelastic botelastic bot added the needs_team Indicates that the issue/PR needs a Team:* label label Mar 29, 2022
@cla-checker-service
Copy link

cla-checker-service bot commented Mar 29, 2022

💚 CLA has been signed

@mergify
Copy link
Contributor

mergify bot commented Mar 29, 2022

This pull request does not have a backport label. Could you fix it @piellick? 🙏
To fixup this pull request, you need to add the backport labels for the needed
branches, such as:

  • backport-v./d./d./d is the label to automatically backport to the 7./d branch. /d is the digit

NOTE: backport-skip has been added to this pull request.

@mergify mergify bot added the backport-skip Skip notification from the automated backport with mergify label Mar 29, 2022
@elasticmachine
Copy link
Collaborator

elasticmachine commented Mar 29, 2022

💚 Build Succeeded

the below badges are clickable and redirect to their specific view in the CI or DOCS
Pipeline View Test View Changes Artifacts preview preview

Expand to view the summary

Build stats

  • Start Time: 2022-04-10T22:55:34.474+0000

  • Duration: 68 min 14 sec

Test stats 🧪

Test Results
Failed 0
Passed 6200
Skipped 728
Total 6928

💚 Flaky test report

Tests succeeded.

🤖 GitHub comments

To re-run your PR in the CI, just comment with:

  • /test : Re-trigger the build.

  • /package : Generate the packages and run the E2E tests.

  • /beats-tester : Run the installation tests with beats-tester.

  • run elasticsearch-ci/docs : Re-trigger the docs validation. (use unformatted text in the comment!)

@andrewkroh
Copy link
Member

@piellick Thank you. Can you please sign the Contributor License Agreement (CLA). https://www.elastic.co/contributor-agreement

@andrewkroh
Copy link
Member

What version of Sophos XG are these logs taken from?

@andrewkroh andrewkroh changed the title Update filerewall.log bench test [sophos] Add sophos XG log samples containing new field names Mar 29, 2022
@elasticmachine
Copy link
Collaborator

Pinging @elastic/security-external-integrations (Team:Security-External Integrations)

@botelastic botelastic bot removed the needs_team Indicates that the issue/PR needs a Team:* label label Mar 29, 2022
@andrewkroh andrewkroh changed the title [sophos] Add sophos XG log samples containing new field names [Filebeat] Add sophos XG log samples containing new field names Mar 29, 2022
@piellick
Copy link
Author

Hi @andrewkroh

What version of Sophos XG are these logs taken from?
18.5.2-MR2 build 380

@piellick Thank you. Can you please sign the Contributor License Agreement (CLA). https://www.elastic.co/contributor-agreement
Done

In meanwhile, i have found this doc who provide sample logs per log type fro 18.5.X version :
https://docs.sophos.com/nsg/sophos-firewall/18.5/PDF/SF%20syslog%20guide%2018.5.pdf
COuld be very helpfull for you.

@andrewkroh
Copy link
Member

Indeed, that is a great resource. Thanks

@efd6
Copy link
Contributor

efd6 commented Mar 31, 2022

Thanks for providing these @piellick. It looks like they have been retained in a quoted document (probably as a JSON string). Is that the case?

@piellick
Copy link
Author

Thanks for providing these @piellick. It looks like they have been retained in a quoted document (probably as a JSON string). Is that the case?

You right @efd6 it's from an filebeat file output. It's the only source i have.

@efd6
Copy link
Contributor

efd6 commented Mar 31, 2022

Great. Thanks for confirming. I will go over it and fix up some of the issues that I noticed if that's OK with you, and generate the expected output so we can merge this.

@efd6 efd6 self-assigned this Apr 6, 2022
@efd6
Copy link
Contributor

efd6 commented Apr 10, 2022

/test

@piellick piellick requested a review from a team as a code owner April 10, 2022 21:21
@efd6
Copy link
Contributor

efd6 commented Apr 10, 2022

/test

@efd6
Copy link
Contributor

efd6 commented Apr 10, 2022

/test

@efd6 efd6 requested a review from andrewkroh April 18, 2022 22:34
@andrewkroh
Copy link
Member

andrewkroh commented Apr 21, 2022

In elastic/integrations#3127 I incorporated the samples from the reference docs you pointed us to (thanks!). I didn't use the samples here b/c I think the documentation samples gives us good coverage. After the new version is out (#31388) if you still have issues let us know.

I am curious if these samples came from the Sophos Log Viewer or were directly from a device over syslog? The reason I ask is because some of the fields, like victim, are not used in the syslog format (it is target).

Screen Shot 2022-04-21 at 16 53 28

@andrewkroh andrewkroh closed this Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backport-skip Skip notification from the automated backport with mergify enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants