Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Port notice generator to Golang #15981

Closed
kvch opened this issue Jan 31, 2020 · 4 comments
Closed

Port notice generator to Golang #15981

kvch opened this issue Jan 31, 2020 · 4 comments
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team

Comments

@kvch
Copy link
Contributor

kvch commented Jan 31, 2020

Currently, the NOTICE.txt file is generated using the Python script dev-tools/generate_notice.py. To integrate better with mage and to utilize Golang specific tools, we should port the script to Golang.

@kvch kvch added the Team:Services (Deprecated) Label for the former Integrations-Services team label Jan 31, 2020
@jsoriano
Copy link
Member

When implementing this we have to take into account that dev-tools/generate_notice.py --csv is used by internal release processes.

@kvch
Copy link
Contributor Author

kvch commented Mar 24, 2020

We should evaluate if we can use this tool instead of creating our own: https://github.com/elastic/cloud-on-k8s/tree/master/hack/licence-detector

@botelastic
Copy link

botelastic bot commented Feb 22, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added the Stalled label Feb 22, 2021
@jsoriano jsoriano removed the Stalled label Feb 22, 2021
@kvch
Copy link
Contributor Author

kvch commented Jun 4, 2021

Closing as have already adopted https://github.com/elastic/go-licence-detector in #18655

@kvch kvch closed this as completed Jun 4, 2021
@zube zube bot removed the [zube]: Done label Sep 2, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Team:Services (Deprecated) Label for the former Integrations-Services team
Projects
None yet
Development

No branches or pull requests

3 participants