Make docs doesn't return errors?

[ph]

I've come across an issue in a build doc in #13336 and I think it's worth investigating, the PR was making the main doc build fails but the "make docs" was working and did not complain at all. I've fixed the issue in #13862.

I think it worth investigating why this is the case, I mean we do test locally the build with make docs and it would be nice that we can have a 1:1 representation of the build.

[andrewkroh]

Looks like the script should be setting the return code:

beats/script/build_docs.sh

Line 3 in cfdae76

set -e

Double-check these (I think they're OK):

beats/Makefile

Lines 132 to 134 in 4131241

	docs:
	@$(foreach var,$(PROJECTS),BUILD_DIR=${BUILD_DIR} $(MAKE) -C $(var) docs || exit 1;)
	sh ./script/build_docs.sh dev-guide github.com/elastic/beats/docs/devguide ${BUILD_DIR}

beats/libbeat/scripts/Makefile

Lines 342 to 347 in 4131241

	docs: ## @build Builds the documentation for the beat
	@if [ -d $(XPACK_DIR) ]; then \
	sh ${ES_BEATS}/script/build_docs.sh ${BEAT_NAME} ${BEAT_PATH}/docs ${BUILD_DIR} ${XPACK_DIR}; \
	else \
	sh ${ES_BEATS}/script/build_docs.sh ${BEAT_NAME} ${BEAT_PATH}/docs ${BUILD_DIR}; \
	fi

[botelastic]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[botelastic]

This issue doesn't have a Team:<team> label.