Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Auditbeat] event.dataset should be "module.metricset" #11995

Closed
andrewkroh opened this issue Apr 30, 2019 · 15 comments
Closed

[Auditbeat] event.dataset should be "module.metricset" #11995

andrewkroh opened this issue Apr 30, 2019 · 15 comments
Labels
Auditbeat needs_team Indicates that the issue/PR needs a Team:* label Stalled

Comments

@andrewkroh
Copy link
Member

andrewkroh commented Apr 30, 2019

To align with both Filebeat and Metricbeat the event.dataset field should be populated by Auditbeat with {module}.{metricset}. Currently the value is populated with only the metricset name (i.e. event.dataset: "socket").

This only affects the system module in Auditbeat.

@andrewkroh
Copy link
Member Author

@ruflin @webmat Do you agree? The system module is still beta so we could make this change now to get alignment.

@ruflin
Copy link
Collaborator

ruflin commented Apr 30, 2019

@andrewkroh Yes! And the event.dataset value should be unique and not overlap with metricbeat (if the data is not the same). But I assume that is already the case? I'm surprised the above is not already the case, because Metricbeat should do the above by default.

@webmat
Copy link
Contributor

webmat commented Apr 30, 2019

Yes, I totally agree!

It's even a clarification I'm in the process of adding to ECS. You can see it here.

I'm not making this a hard requirement over there, as I have in mind other implementers as well. But I think it would be best if we strived to do that as much as possible within the Elastic Stack.

@andrewkroh
Copy link
Member Author

@ruflin Auditbeat has some slightly different handling from Metricbeat because the auditd and file_integrity modules don't have "datasets".

// Modules without "datasets" should set their module and metricset names
// to the same value then this will omit the event.dataset field.

@ruflin
Copy link
Collaborator

ruflin commented Apr 30, 2019

Got it, I slightly remember a discussion around this.

I'm thinking if we should rename event.Namespace to event.Namespace because now that we switched everything over to the new reporter, that is what it is used for mostly: https://github.com/elastic/beats/blob/master/metricbeat/mb/event.go#L124 Or we should introduce event.Dataset and move it over gradually.

@exekias FYI

@urso
Copy link

urso commented Jan 17, 2020

@exekias @andrewkroh Is this issue resolved by now, or would it be a breaking change and we should postpone this to 8.0?

@consulthys
Copy link
Contributor

@ruflin any insights about this one and an idea if/when the change will make it? Thank you so much!

@ruflin
Copy link
Collaborator

ruflin commented Nov 30, 2020

@consulthys What part are you worried about, the internals of MB or what the end event might look like? One thing that changed since we discussed this is that we introduced a new indexing strategy which might give a new perspective on this issue.

@consulthys
Copy link
Contributor

@ruflin yes, that's exactly the new indexing strategy (%{type}-%{event.dataset}-%{namespace}) that got me thinking. My question is how does Auditbeat approach the new indexing strategy? Will event.dataset be filled in?

@ruflin
Copy link
Collaborator

ruflin commented Dec 1, 2020

@consulthys The fields used for the new indexing strategy are data_stream.*: elastic/ecs#1145 These are added by the Elastic Agent when running a Beat. Today we do not support Auditbeat yet but if we add it, these 3 fields must be filled in.

@consulthys
Copy link
Contributor

@ruflin thank you very much for mentioning which fields are actually used to create the index name 👍
But can you also give a quick insight on which part of the pipeline will actually be using those three fields to create the final index name? Is it a processor on Agent/Beats side or an ingest pipeline on ES side?

@ruflin
Copy link
Collaborator

ruflin commented Jan 4, 2021

Currently it the data stream selection is done by the Elastic Agent. Elasticsearch will use the fields to set the correct mappings.

Here is also a first blog post that describes these fields a bit more in detail: https://www.elastic.co/blog/an-introduction-to-the-elastic-data-stream-naming-scheme

@botelastic
Copy link

botelastic bot commented Jan 27, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@botelastic botelastic bot added Stalled needs_team Indicates that the issue/PR needs a Team:* label labels Jan 27, 2022
@botelastic
Copy link

botelastic bot commented Jan 27, 2022

This issue doesn't have a Team:<team> label.

@mtojek
Copy link
Contributor

mtojek commented Jan 28, 2022

Stale, resolving

@mtojek mtojek closed this as completed Jan 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Auditbeat needs_team Indicates that the issue/PR needs a Team:* label Stalled
Projects
None yet
Development

No branches or pull requests

6 participants