-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Introduce host.id attribute to traces #4368
Comments
Pinging: @kaiyan-sheng @exekias @sorantis Are those fields the same? Or would it make more sense to align around cloud.instance.id? |
The OTel spec is vague in the non-cloud case though. In that case what is the unique ID? Is it |
We are suggesting
I would say FQDN works better, machine-id can only retrieved from inside the machine, so while it guarantees to be unique, it's not very useful for correlation (specifically to correlate events coming from monitoring the machine from outside vs inside). |
@cyrille-leclerc - any chance you know how OTel defines host.id in non-cloud environments? |
Yes we are also using |
@axw my understanding is that the only I collected the documents of the transaction and all the spans of a trace. Unfortunately, everything runs on my local Macbook without Docker making it more difficult to understand the usage of the @axw Could we have omitted to map other Otel host attributes? I looked at https://github.com/open-telemetry/opentelemetry-collector-contrib/blob/master/exporter/elasticexporter/internal/translator/elastic/traces.go but I didn't find any hint. |
Yes; what is there is not comprehensive. We will need to add support for translating |
@alex-fedotyev OpenTelemetry Research notes
|
#4955 will add We still need some conclusion on what to do for our agents. We could just set it to cloud instance ID for now, when it's set.
@exekias does beats already do this? I just took a quick look and it appears to be using go-sysinfo's "HostInfo.UniqueID", which is populated using machine-id. |
Not yet, right now beats report |
Sorry I just saw this message 🤕 Yes here is the issue: elastic/beats#22739 |
Metrics and logs identified a problem of using host.name for correlation when ingesting data from cloud environments, as they don't provide proper host name.
Proposed solution is to introduce host.id field which is "calculated" and is equal host.name for on-premises environments, and for cloud it is equal cloud.instance.id.
Original issue and spreadsheet with the breakdown.
This seems to align well with OTel spec, as they are using cloud instance_id as the host.id.
The proposal for APM is to calculate host.id dynamically based on whether cloud metadata is present or using host.name otherwise.
We would leverage this when integrating products together, i.e. linking from Infra to APM and vice versa.
We would also need to recognize host.id when ingesting data from OTel.
CC: @graphaelli @felixbarny
The text was updated successfully, but these errors were encountered: