Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Do not de-dot metrics if communicating with APM Server 8.3+ #2635

Open
eyalkoren opened this issue May 18, 2022 · 3 comments
Open

Do not de-dot metrics if communicating with APM Server 8.3+ #2635

eyalkoren opened this issue May 18, 2022 · 3 comments
Labels
agent-java blocked

Comments

@eyalkoren
Copy link
Contributor

Context: elastic/apm#347 (comment)

If communicating with APM Server 8.3 or newer, we should not dedot metrics by default.
If there's no good reason to allow dedotting through configuration, we may simply ignore the dedot_custom_metrics in such cases.
@eyalkoren eyalkoren changed the title Do not dedot metrics if communicating with APM Server 8.3+ Do not de-dot metrics if communicating with APM Server 8.3+ May 18, 2022
@axw
Copy link
Member

axw commented May 18, 2022

The changes that could enable this exist in Elasticsearch, but we're not yet using them. We'll need to wait for a later release.

@eyalkoren
Copy link
Contributor Author

Right, I jumped the gun on this...
Do you have an APM Server issue to link to?

@axw
Copy link
Member

axw commented May 18, 2022

Not yet -- I'll open one when elastic/apm#347 (comment) is resolved.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
agent-java blocked
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@axw @eyalkoren