Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow custom cors headers to be supplied via serverless.yml #74

Closed
wants to merge 1 commit into from
Closed

Allow custom cors headers to be supplied via serverless.yml #74

wants to merge 1 commit into from

Conversation

Whoaa512
Copy link

@Whoaa512 Whoaa512 commented Jan 4, 2017

No description provided.

@thenikso
Copy link
Contributor

thenikso commented Jan 9, 2017

this looks all right, I also like the documentation. However wouldn't it be easier to use a Access-Control-Allow-Headers: * instead?

@Whoaa512
Copy link
Author

Whoaa512 commented Jan 9, 2017

I agree that '*' is easier and will incorporate that change.

Also I think we could get closer to the serverless configuration (See)

Will try to incorporate that as well and see what you think.

@jelder jelder mentioned this pull request Apr 17, 2017
Closed
@HyperBrain HyperBrain mentioned this pull request Jun 30, 2017
Closed
@Whoaa512
Copy link
Author

Closing in favor of using serverless-offline

@Whoaa512 Whoaa512 closed this Jun 30, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Whoaa512 @thenikso