Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

clean nodegroup deletion #536

Closed
errordeveloper opened this issue Feb 12, 2019 · 5 comments
Closed

clean nodegroup deletion #536

errordeveloper opened this issue Feb 12, 2019 · 5 comments
Assignees
Labels
area/aws-vpc area/deletions area/general-cli area/nodegroup kind/improvement priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases

Comments

@errordeveloper
Copy link
Contributor

errordeveloper commented Feb 12, 2019

As mentioned earlier in #523 (comment), we need to devise a better strategy for nodegroup deletion, which should also help us with #103 and #274 (as well as other related issues).

So we should try implementing the following strategy:

  • for all nodegroups
    • taint the node and drain pods
  • delete all daemonsets
  • for all nodegroups
    • scale nodes to zero
    • delete dangling ENIs
    • look for ELBs, ALBs and EBS volumes and delete those
      • also ALBs created through Ingress
  • delete each nodegroup stack
  • delete cluster stack

We may do something different for deleting individual nodegroups, e.g. only scale drain, taint and down, but we do need to implement this first, as deletion is an important aspect of user experience.

related: #2278, #2172

@errordeveloper
Copy link
Contributor Author

Maybe related to aws/amazon-vpc-cni-k8s#69.

@errordeveloper
Copy link
Contributor Author

Fixing this would pave the road towards fixing other issue with deletions.

@gemagomez
Copy link

@2opremio is this finished?

@gemagomez gemagomez added this to the 0.4.0 milestone Jul 31, 2019
@2opremio
Copy link
Contributor

Nope, I fixed #103 in a different way and haven't tackled #274 yet for which we may follow a different approach.

@aclevername aclevername self-assigned this Sep 3, 2021
@nikimanoledaki nikimanoledaki changed the title clean nodegroup deletion eksctl delete cluster should delete all nodegroups and their associated resources Sep 6, 2021
@nikimanoledaki nikimanoledaki changed the title eksctl delete cluster should delete all nodegroups and their associated resources clean nodegroup deletion Sep 6, 2021
@nikimanoledaki
Copy link
Contributor

What was left to do was draining the nodegroups and deleting the daemonsets. This was addressed so this issue can be closed now.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/aws-vpc area/deletions area/general-cli area/nodegroup kind/improvement priority/important-longterm Important over the long term, but may not be currently staffed and/or may require multiple releases
Projects
None yet
Development

No branches or pull requests

6 participants