Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

IAM Role, missing Path property #279

Closed
mdgm88 opened this issue Sep 8, 2024 · 4 comments · Fixed by #283
Closed

IAM Role, missing Path property #279

mdgm88 opened this issue Sep 8, 2024 · 4 comments · Fixed by #283
Labels

Comments

@mdgm88
Copy link

mdgm88 commented Sep 8, 2024

It looks like at least some of the changes from rebuy-de/aws-nuke#914 are missing, especially for iam-roles.go

I would like to exclude roles in particular paths from being deleted.

@ekristen
Copy link
Owner

ekristen commented Sep 8, 2024

Interesting. I'll take a look. Things diverged back in December, I thought I had captured all the changes since, but might have missed something.

@mdgm88
Copy link
Author

mdgm88 commented Sep 8, 2024

It might just be for iam-roles.go. Especially in https://github.com/ekristen/aws-nuke/blob/main/resources/iam-roles.go#L67C1-L73C5

The properties for the Name, Path etc. for the role are missing that were added in the PR mentioned above.

@ekristen
Copy link
Owner

ekristen commented Sep 8, 2024

Weird. Not sure how that happened, I'll take a look.

@ekristen
Copy link
Owner

🎉 This issue has been resolved in version 3.18.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants