Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gahoot does not work over SSL #2

Closed
KekoaM opened this issue Nov 1, 2023 · 2 comments · Fixed by #3
Closed

Gahoot does not work over SSL #2

KekoaM opened this issue Nov 1, 2023 · 2 comments · Fixed by #3

Comments

@KekoaM
Copy link

KekoaM commented Nov 1, 2023

Mobile browsers cannot connect to Gahoot games due to websocket security mismatches.

Steps to reproduce:

  1. Run Gahoot behind a reverse proxy providing SSL termination
  2. Connect to Gahoot on a mobile browser using https
  3. Join a Gahoot game

Attempted fixes:

  • Changing the client side js use only wss for secure websockets
    • This fix only works for Gahoot servers that use SSL, causing http-only sessions to break
@ejv2
Copy link
Owner

ejv2 commented Nov 1, 2023

Thanks for the report! I had no idea this was a problem (shows how much I know about mobile). I think the best way of doing this would be to add a configuration variable which tells Gahoot if SSL is to be used. If so, pass something to the client which mirrors the SSL flag and enables wss. That way, we get to preserve HTTP sessions which are already in use.

@ejv2 ejv2 mentioned this issue Nov 11, 2023
@ejv2
Copy link
Owner

ejv2 commented Nov 11, 2023

I've written something similar to what I posted last week. Please pull the latest from the ssl branch and see if it fixes your issue.

@ejv2 ejv2 closed this as completed in #3 Aug 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants