From af50b2e7be2fdd51eed33d091f4ac1f5c0545bc4 Mon Sep 17 00:00:00 2001 From: Surya Sashank Nistala Date: Mon, 27 Nov 2023 15:31:18 -0800 Subject: [PATCH] Revert "add fields param in toxcontent() for doc level query (#549) (#555)" This reverts commit dcf288df8379f7cc0cce1b248e3c4c84dd11b18b. Signed-off-by: Surya Sashank Nistala --- .../commons/alerting/model/DocLevelQuery.kt | 1 - .../commons/alerting/model/XContentTests.kt | 12 ------------ 2 files changed, 13 deletions(-) diff --git a/src/main/kotlin/org/opensearch/commons/alerting/model/DocLevelQuery.kt b/src/main/kotlin/org/opensearch/commons/alerting/model/DocLevelQuery.kt index ba3e4e4c..576be89b 100644 --- a/src/main/kotlin/org/opensearch/commons/alerting/model/DocLevelQuery.kt +++ b/src/main/kotlin/org/opensearch/commons/alerting/model/DocLevelQuery.kt @@ -59,7 +59,6 @@ data class DocLevelQuery( builder.startObject() .field(QUERY_ID_FIELD, id) .field(NAME_FIELD, name) - .field(FIELDS_FIELD, fields.toTypedArray()) .field(QUERY_FIELD, query) .field(TAGS_FIELD, tags.toTypedArray()) .endObject() diff --git a/src/test/kotlin/org/opensearch/commons/alerting/model/XContentTests.kt b/src/test/kotlin/org/opensearch/commons/alerting/model/XContentTests.kt index 7c52ff42..a284c187 100644 --- a/src/test/kotlin/org/opensearch/commons/alerting/model/XContentTests.kt +++ b/src/test/kotlin/org/opensearch/commons/alerting/model/XContentTests.kt @@ -417,18 +417,6 @@ class XContentTests { ) } - @Test - fun `test doc level query toXcontent`() { - val dlq = DocLevelQuery("id", "name", listOf("f1", "f2"), "query", listOf("t1", "t2")) - val dlqString = dlq.toXContent(builder(), ToXContent.EMPTY_PARAMS).string() - val parsedDlq = DocLevelQuery.parse(parser(dlqString)) - Assertions.assertEquals( - dlq, - parsedDlq, - "Round tripping Doc level query doesn't work" - ) - } - @Test fun `test alert parsing`() { val alert = randomAlert()