New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use optional/required etag, when available, in Delete method tests #239

Closed

fredrikaverpil opened this issue Jun 27, 2024 · 1 comment

Member

fredrikaverpil commented Jun 27, 2024 •

edited

Loading

AIP-135 talks about Protected Delete, which entails requiring etag in the proto.

However, the tests for the Delete method does not take etag into account right now. We aim to fix this and is internally tracked as TRA-1554.

Note: there is a conflicting bug in googleapis/api-linter for this currently: googleapis/api-linter#1395

Member

thall commented Oct 4, 2024

@fredrikaverpil can this be closed now since we have tests takes the etag into account?
https://github.com/einride/protoc-gen-go-aip-test/blob/master/internal/aiptest/deletion/etag.go

fredrikaverpil closed this as completed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment