feat: add interface #216
Merged
feat: add interface #216
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It'll be easier to mock candevice functionality in other packages.
Edholm
reviewed
Sep 28, 2023
There was a problem hiding this comment.
It's good that we have an interface, but I'm not sure I agree with returning the interface from the New func.
Go generally follows "Accept interfaces, return structs" and since Go implicitly implements any matching interface, I don't think this justifies changing the function signature.
Could you give me an example where this solves a problem that can't be solved in another way?
|
hmm indeed there is no need to change function signature here, I'll change it.
Just want to add that of course nothing prevents users from defining interface in their own packages but it makes it easier for them if it's defined here. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It'll be easier to mock candevice functionality in other packages.