Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: fix sourcemap behavior #349

Merged
merged 3 commits into from
Aug 26, 2022
Merged

fix: fix sourcemap behavior #349

merged 3 commits into from
Aug 26, 2022

Conversation

KingSora
Copy link
Contributor

@KingSora KingSora commented Aug 20, 2022 •
edited by egoist
Loading

Currently the plugin will always transform the code with sourcemap: false, because the outputOptions hook runs after the transform hook. I've adapted this behavior in this PR and added tests

should also fix #329 and fix #333

@KingSora
Copy link
Contributor Author

cc @egoist

@egoist
Copy link
Owner

egoist commented Aug 26, 2022

I made sourceMap: true by default cause this will make it easier to actually emit sourcemap files, you only need to set output.sourcemap: true in the rollup config.

@egoist egoist changed the title fix sourcemap behavior fix: fix sourcemap behavior Aug 26, 2022
@egoist egoist merged commit 61df802 into egoist:dev Aug 26, 2022
@github-actions
Copy link

🎉 This PR is included in version 4.10.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

sourceMaps option is always false while making call to getRenderChunk Generated sourcemap maybe broken
2 participants
@KingSora @egoist