feat: Support Webpack 5 #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… with describe.each
…works on both Webpack 4 and Webpack 5 The Sources returned in the stats.compilation on Webpack 5 don't support reading their contents. So, let's just read the written output, which is a slightly more thorough test anyways. The snapshots didn't need to be updated so I think this is working well.
Uses the new processAssets compiler hook to avoid deprecation warnings and undefined methods.
|
I'm not too familiar with Webpack 5 yet, but assuming you are or that you have projects that use it. I compared with how Do you know if they're necessary? |
|
👍 thanks for running with the PR! I honestly am a bit of a webpack amateur so I'm not really sure, but as best I understand it, we should do both those things too! Good idea to check. The hash update makes a lot of sense to me to ensure CDN cache busting and whatnot when the esbuild options change, and the stats printer seems like a nice to have for operators. |
|
🎉 This PR is included in version 2.2.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Original PR: #21