Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Async init renders #201

Merged
merged 11 commits into from
Sep 1, 2020
Merged

Async init renders #201

merged 11 commits into from
Sep 1, 2020

Conversation

egil
Copy link
Member

@egil egil commented Sep 1, 2020

Pull request description

PR meta checklist

  • Pull request is targeting at DEV branch.
  • Pull request is linked to all related issues, if any.
  • I have read the CONTRIBUTING.md document.

Content checklist

  • My code follows the code style of this project and AspNetCore coding guidelines.
  • My change requires a change to the documentation.
    • I have updated the documentation accordingly.
  • I have updated the appropriate sub section in the CHANGELOG.md.
  • I have added, updated or removed tests to according to my changes.
    • All tests passed.

@codecov
Copy link

codecov bot commented Sep 1, 2020

Codecov Report

Merging #201 into dev will increase coverage by 0.45%.
The diff coverage is 90.90%.

Impacted file tree graph

@@            Coverage Diff             @@
##              dev     #201      +/-   ##
==========================================
+ Coverage   77.86%   78.31%   +0.45%     
==========================================
  Files          99      102       +3     
  Lines        2864     2956      +92     
  Branches      353      371      +18     
==========================================
+ Hits         2230     2315      +85     
  Misses        518      518              
- Partials      116      123       +7     
Impacted Files Coverage Δ
...bunit.core/Rendering/ComponentDisposedException.cs 100.00% <ø> (ø)
src/bunit.web/Diffing/BlazorDiffingHelpers.cs 71.42% <ø> (ø)
src/bunit.web/Diffing/DiffMarkupFormatter.cs 58.33% <ø> (ø)
src/bunit.web/Diffing/HtmlComparer.cs 76.92% <ø> (ø)
...spatchExtensions/GeneralEventDispatchExtensions.cs 100.00% <ø> (ø)
src/bunit.web/RazorTesting/SnapshotTest.cs 73.91% <ø> (ø)
src/bunit.web/Extensions/TestRendererExtensions.cs 58.82% <58.82%> (ø)
src/bunit.web/Rendering/RenderedFragment.cs 80.00% <83.67%> (+1.42%) ⬆️
src/bunit.core/Rendering/RenderEvent.cs 93.10% <85.71%> (-1.35%) ⬇️
src/bunit.web/Rendering/RenderedComponent.cs 88.23% <86.66%> (-11.77%) ⬇️
... and 17 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c72bee0...29ff6e6. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Sep 1, 2020

Kudos, SonarCloud Quality Gate passed!

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities (and Security Hotspot 0 Security Hotspots to review)
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@egil egil marked this pull request as ready for review September 1, 2020 22:05
@egil egil merged commit 9ed7f33 into dev Sep 1, 2020
@egil egil deleted the async-init-renders branch September 1, 2020 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants