-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace django-fernet-fields dependency #1
Comments
django-fernet-fields is compatible with django 3.2, but it triggers the following warning:
I propose the following:
Let me know if the approach above works for you. If yes, I can take care of it. EDIT: to reproduce the issue, I did the following steps:
@jmbowman you can assign the issue to me. |
Sorry for the delayed response, I tried and failed to delegate this and a few other tasks. If the current PyPI release works with 3.2 and we just need to put up with the deprecation warnings for 4.0, I'm inclined to stick with that for now and offer assistance on orcasgit/django-fernet-fields#28 . The https://github.com/dstarner/django-fernet-fields fork has already been created with some updates, and there's also a recent proposal to move the project to Jazzband. @regisb , does this sound reasonable to you? If so, I think we can just close this. |
Given the urgency of the Django 3.2 upgrade, I agree that we can live with a simple deprecation warning. Feel free to close this. |
leaving a note here for future django 4 upgrade work. a new fork of django-fernet-fields called djfernet supports django 4, is backwards compatible with existing settings/data (>= 0.8.0), and is published in pypi orcasgit/django-fernet-fields#28 (comment) I may be able to help execute upgrading/migrating to this library as part of our upcoming edx-enterprise work where we want to make use of encrypted columns. |
@johnnagro our team is working on |
It looks like some usage of django-fernet-fields has already been replaced with djferent (and some repos like edx-platform use both for some reason): https://github.com/search?q=user%3Aopenedx+django-fernet-fields&type=code . And the djfernet maintainer did test against Django 4.1 6 months ago: https://yourlabs.io/oss/djfernet/-/issues/3 . Could we try submitting a PR for the usual CI, Trove classifier, etc. updates and see if it gets merged and released? We could still fork ourselves or try migrating to https://pypi.org/project/django-fernet-encrypted-fields/ if there isn't a timely response. If it's truly a drop-in replacement, I'd rather consolidate onto one of the 2 packages we already use and then follow up on the topic of long-term maintenance after the Django 4.2 upgrade is complete. |
@jmbowman it looks like we're using |
Yes, Arbi-BOM ultimately settled on django-fernet-fields-v2 and has been switching to that in the course of preparing for the Django 4.2 upgrade: #215 . |
We use the django-fernet-fields package in edx/edx-enterprise, edx/edx-enterprise-data, edx/edx-platform, edx/edx-val, edx/event-routing-backends, and edx/video-encode-manager, but it was abandoned in January; details and a potentially upcoming fork can be found in orcasgit/django-fernet-fields#28 . Please follow the guidance in https://openedx.atlassian.net/wiki/spaces/AC/pages/3036972032/Handling+Outdated+Dependencies to resolve the problem this poses for the Open edX Django 3.2 upgrade.
The text was updated successfully, but these errors were encountered: