-
Notifications
You must be signed in to change notification settings - Fork 3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update repos with setup.py changes for package extras #386
Comments
I think there might be some more tweaks to make first—see this old comment about commas: openedx/edx-cookiecutters#154 (I might go ahead and make a PR for that.) |
Tim plans to make a fix to the script, then pass along to Arbi-BOM to run across the repos. |
PR for adding better extras support, although at the moment it's not as well tested as I would like: openedx/edx-cookiecutters#379 [EDIT] Done. |
Ready for Arbi-BOM to pick up. |
Hi @timmc-edx , Can you please review this testing PR? I've just run a script on one repo(for testing). Is everything looks good? If so I can run bulk job to do this in all the repos. |
@timmc-edx @iamsobanjaved: This ticket is marked "Done" on the arch-bom board, and in "Author Team Review" on the Arbi-BOM board. If it is Done for everyone, please close the issue. If it is done for arch-bom, but not for arbi-bom, maybe arch-bom should just remove it from our board? |
Yes @robrap, you can remove from your board. Team is currently occupied with some deadline bound tasks, hence moving back to Todo section and once someone has bandwidth to pursue these PRs, will be picked again. |
Thanks @iamsobanjaved. Looks like this was archived in arch-bom. All good. |
openedx/edx-cookiecutters#377 and openedx/edx-cookiecutters#379 made changes to setup.py in cookiecutters to improve the handling of package extras. We should run the update script against all our package repositories to pick up the change.
Before updating:
The text was updated successfully, but these errors were encountered: