RTL fixes

[pomegranited]

Description

Introduce proper right-to-left support for the following:

• Alignment of overall feedback message icons and text
• Alignment and borders of sidebar buttons
• Margin of the "You have used X attempts" message

Dependencies

None

JIRA

• SOL-2031

Sandbox URLs

• LMS
• Studio

Latest commit

• fe49f58 (updated 2016-09-14)

Testing instructions

1. Go to the pre-deployed assessment-mode block on the LMS, and log in as staff@example.com.
2. Click on Staff Debug Info, and Delete Student State for the staff@example.com user. Close the modal.
3. Pick a regular item and place it correctly in its zone. Click submit, and notice that there are now 3 overall feedback messages, all of them correctly aligned.
4. Update the language to ar.
5. Go back to the block and refresh the page.
6. Notice that in Arabic, the feedback message icons are properly aligned on the right.
7. Notice that the sidebar buttons (reset and keyboard help) are properly aligned on the left.
8. Notice that the "You have used X attempts" message is properly spaced away from the submit button.

Screenshots

Reviewers

• OpenCraft: @pomegranited
• TNL: @cahrens or @staubina
• a11y: @cptvitamin or @clrux - did you want to have a look at this too?
• Product: @marcotuts (CC @sstack22)

[openedx-webhooks]

Thanks for the pull request, @pomegranited! It looks like you're a member of a company that does contract work for edX. If you're doing this work as part of a paid contract with edX, you should talk to edX about who will review this pull request. If this work is not part of a paid contract with edX, then you should ensure that there is an OSPR issue to track this work in JIRA, so that we don't lose track of your pull request.

To automatically create an OSPR issue for this pull request, just visit this link: https://openedx-webhooks.herokuapp.com/github/process_pr?number=102&repo=edx-solutions%2Fxblock-drag-and-drop-v2

[cahrens]

These changes are also included in #103, correct?

[pomegranited]

@cahrens My apologies! I accidentally merged this branch into our fork, and when @arbrandes rebased his branch for #103, it included those changes in that PR as well.

How would you like me to proceed? I can combine the review for both PRs into #103 and close this PR.. or try to untangle the merge.. or leave things as-is?

[cahrens]

@pomegranited no problem-- I'd say close this PR and just have the review be in #103.

[pomegranited]

Closing this PR as the changes are included in #103.

[arbrandes]

@pomegranited, sorry for my part in the confusion with the rebase. I mistook the merge to opencraft master as having come from edx-solutions master.