Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add "pino" as a Dependency #299

Open
igorlamos opened this issue Sep 29, 2024 · 0 comments
Open

Add "pino" as a Dependency #299

igorlamos opened this issue Sep 29, 2024 · 0 comments

Comments

@igorlamos
Copy link

You're importing pino in https://github.com/edwinhern/express-typescript-2024/blob/master/src/server.ts#L4 yet package.json does not define this dependency.

Seems like it works with some package managers because pino is installed as a phantom dependency.

I've been trying it with Rush + PNPM setup where phantom dependencies "issue" is solved out-of-box, therefore I've found this minor issue.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@igorlamos