Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suboptimal interpolation when training the detail predictor #7

Open
MarkTension opened this issue Jun 27, 2023 · 2 comments
Open

Suboptimal interpolation when training the detail predictor #7

MarkTension opened this issue Jun 27, 2023 · 2 comments

Comments

@MarkTension
Copy link

Hello, thank you for sharing your code!
I'd like to bring your attention to how F.interpolate is being used for training the detail predictor, in line:
https://github.com/edward1997104/Wavelet-Generation/blob/main/trainer/trainer.py#L260C33-L260C46

The interpolation mode is not set, and defaults to 'linear'. Setting mode='trilinear' gives better results (because it uses the 3 spatial dimensions instead of 1) and gets rid of some of the artifacts that I see in the results. Cheers!

@MarkTension
Copy link
Author

EDIT: Sorry, it defaults to 'nearest', but still I think 'trilinear' is more desirable.

@edward1997104
Copy link
Owner

Oh... It is really nice for you to find out that as we used to consider this a design decision! We might test it out later to provide an updated model!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants