Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

perf: add compatibility with nutmeg release #94

Merged
merged 5 commits into from
Oct 9, 2022
Merged

perf: add compatibility with nutmeg release #94

merged 5 commits into from
Oct 9, 2022

Conversation

Henrrypg
Copy link
Contributor

@Henrrypg Henrrypg commented Oct 6, 2022

This PR is to add compatibility with nutmeg release

How to test

You can run this strain:

STRAIN_NAME: nutmeg
STRAIN_TUTOR_VERSION: v14.0.5
DEV_PROJECT_NAME: nutmeg_dev
LOCAL_PROJECT_NAME: nutmeg_local
CMS_HOST: studio.nutmeg.edunext.link
LMS_HOST: lms.nutmeg.edunext.link
PLATFORM_NAME: Distro nutmeg
STRAIN_TUTOR_PLUGINS:
  - REPO: tutor-contrib-edunext-distro
    VERSION: v3.0.0-rc1
    EGG: tutor-contrib-edunext-distro==v3.0.0-rc1
    PACKAGE_NAME: distro
    PROTOCOL: ssh
  - REPO: tutor-forum
    VERSION: v14.0.0
    EGG: tutor-forum==v14.0.0
    PATH: overhangio
    PACKAGE_NAME: forum
STRAIN_EXTRA_COMMANDS:
  - APP: 'tutor'
    COMMAND: 'distro enable-themes'
STRAIN_VOLUME_OVERRIDES:
  edxapp:
    - DESTINATION: ../../src/edxapp/edx-platform
      LOCATION: /openedx/edx-platform
    - DESTINATION: ../../src/edxapp/eox-core
      LOCATION: /openedx/extra_deps/eox-core
    - DESTINATION: ../../src/edxapp/eox-tagging
      LOCATION: /openedx/extra_deps/eox-tagging
STRAIN_EXPORT_VOLUMES:
  - CONTAINER: lms
    LOCATION: /openedx/edx-platform
    DESTINATION: src/edxapp/edx-platform
  - CONTAINER: lms
    LOCATION: /openedx/extra_deps/eox-core
    DESTINATION: src/edxapp/eox-core
  - CONTAINER: lms
    LOCATION: /openedx/extra_deps/eox-tagging
    DESTINATION: src/edxapp/eox-tagging
DISTRO_EOX_CORE_DPKG:
  index: git
  name: eox-core
  private: false
  repo: eox-core
  domain: github.com
  path: eduNEXT
  protocol: https
  variables:
    development: {}
    production: {}
  version: mfmz/compatible-with-nutmeg
DISTRO_EOX_TAGGING_DPKG:
  index: git
  name: eox-tagging
  private: false
  repo: eox-tagging
  domain: github.com
  path: eduNEXT
  protocol: https
  variables:
    development: {}
    production: {}
  version: DS-253

with:

stack strain create
stack strain dev configure -k export_vols -k override_vols
stack strain dev init
stack strain dev configure -s export_vols -s override_vols
stack strain dev start

Then you can follow test cases

@github-actions github-actions bot added the size/m label Oct 6, 2022
@MaferMazu
Copy link
Contributor

@Henrrypg can you add some description in the PR and add python 3.10 support? Openedx-events is not a requirement and I think you can add Python 3.10. Please correct me if I am wrong 😊🙌

Copy link
Contributor

@MaferMazu MaferMazu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please update the PR title and description before the merge 😊

@Henrrypg
Copy link
Contributor Author

Henrrypg commented Oct 6, 2022

Please update the PR title and description before the merge blush

@MaferMazu Thank you, This PR is draft for now, the idea is working with this branch to complete the entire migration, for this reason so far I have not added desription

@MaferMazu
Copy link
Contributor

MaferMazu commented Oct 6, 2022

@Henrrypg Oh thanks for the clarification, I'm going to remove my approval to review all the migration. But for now:

  • Drop circleci
  • Requirements updated
  • Drop support to Django22 and add Python3.10
  • Added workflow to publish in Pypi
  • README updated
  • Github test passed

@MaferMazu MaferMazu self-requested a review October 6, 2022 20:44
@Henrrypg Henrrypg changed the title DRAFTt: drop django 22 and try except from backends perf: drop django 22 and try except from backends Oct 7, 2022
@Henrrypg Henrrypg changed the title perf: drop django 22 and try except from backends perf: add compatibility with nutmeg release Oct 7, 2022
@MaferMazu
Copy link
Contributor

This PR takes into account all the steps of the migration, the only thing is that I still need to try the test cases, but I have had problems with the postman collection to test. So if someone else has already tried the test case and it works, that's fine with me; otherwise, when I can import the collection, I'll test the test cases.

@Henrrypg
Copy link
Contributor Author

Henrrypg commented Oct 8, 2022

This PR takes into account all the steps of the migration, the only thing is that I still need to try the test cases, but I have had problems with the postman collection to test. So if someone else has already tried the test case and it works, that's fine with me; otherwise, when I can import the collection, I'll test the test cases.

Hello @MaferMazu the Jira card in updated with de correct postman json, @dcoa and @dsg-edn already tested the test cases.

@Henrrypg Henrrypg merged commit 95e94ef into master Oct 9, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants