-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
perf(DS-368): add support for olive Open edX release #24
Conversation
I've been testing the plugin and works as expected, no errors. |
@MaferMazu: can you include the complete traceback from the lms-worker? |
Here is the output from the lms-worker:
We can take a look tomorrow. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I could fix it with @mariajgrimaldi's help. We need to add eox-audit-model in INSTALLED_APPS, eox-core did it for us here. I installed eox-core in lms-worker and it's working.
This PR looks good to me ✨
BREAKING CHANGE: add compatibility with olive
Description
This PR adds support for the olive release maintaining the current support for nutmeg. It was tested on the two local environments.
Testing instructions
Setting up the environment:
python manage.py lms migrate eox_audit_model
(LMS)CELERY_ALWAYS_EAGER = False
to your development settings.Generating audit entries using eox-core:
audit
. You'll see the new record generated by the transaction.Additional information
Detailed test cases:
https://docs.google.com/document/d/1v6mxFSf1k7JrxU36Ok9uVDFBhtxVuGmhFLtxtbIsPFs
Checklist for Merge