Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use AssetWriter and AssetReader for correct path access #7

Merged
merged 3 commits into from
Jun 4, 2024

Conversation

hiratara
Copy link
Contributor

@hiratara hiratara commented Jun 4, 2024

Hello,

I noticed that bevy_slippy_tiles cannot find the correct assets/ directory when working in a cargo workspace project. This PR addresses the issue by utilizing the AssetServer from Bevy. Please note that since AssetReader does not have an API to check if a file exists, we must open the file in a blocking manner.

src/lib.rs Show resolved Hide resolved
Copy link
Owner

@edouardpoitras edouardpoitras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Thanks!

@edouardpoitras
Copy link
Owner

Will release this to crates.io as part of 0.5.2

@edouardpoitras edouardpoitras merged commit 766aac1 into edouardpoitras:main Jun 4, 2024
3 checks passed
@hiratara hiratara deleted the asset_writer branch July 5, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants