Rk3588Mem.c - inconsistent Base System RAM length #104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The Base System RAM section nominally starts at `mSystemMemoryBase` but computes its length as if it starts at `0`. This happens to be fine since `mSystemMemoryBase` actually is `0`, so this doesn't cause any real problems, but it seems inconsistent to use a symbol in one place and an implicitly-hard-coded `0` elsewhere. Fix is to use subtract the value of `mSystemMemoryBase` from the length. Since `mSystemMemoryBase` is `0`, this is a no-op, but it makes the table use consistent logic, and might avoid a future issue if this code is ever copy-pasted somewhere that base is not 0.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Base System RAM section nominally starts at
mSystemMemoryBasebut computes its length as if it starts at0. This happens to be fine sincemSystemMemoryBaseactually is0, so this doesn't cause any real problems, but it seems inconsistent to use a symbol in one place and an implicitly-hard-coded0elsewhere.Fix is to use subtract the value of
mSystemMemoryBasefrom the length. SincemSystemMemoryBaseis0, this is a no-op, but it makes the table use consistent logic, and might avoid a future issue if this code is ever copy-pasted somewhere that base is not 0.