feat(snap): Support for snap options to set environment variables #553
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR will add support for setting environment variables for the service, via snap options.
In addition:
disable
which means the service no longer starts by default. This is needed to allow setting the environment variables before the service start, dropping the need for a manual restart.This change may be considered a breaking change and needs further investigation. In particular, need to test if an upgrade from an older version results in a stopped service or not.If your build fails due to your commit message not passing the build checks, please review the guidelines here: https://github.com/edgexfoundry/edgex-ui-go/blob/main/.github/Contributing.md
PR Checklist
Please check if your PR fulfills the following requirements:
BREAKING CHANGE:
describing the break)Testing Instructions
Access http://localhost:4000
New Dependency Instructions (If applicable)
The new dependency (
github.com/canonical/edgex-snap-hooks/v2
) has been approved in the past and used in other Go projects: