Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor and improve the Camera Sensor and example #78

Open
edbeeching opened this issue Mar 1, 2023 · 3 comments
Open

Refactor and improve the Camera Sensor and example #78

edbeeching opened this issue Mar 1, 2023 · 3 comments
Milestone

Comments

@edbeeching
Copy link
Owner

No description provided.

@edbeeching edbeeching added this to the 0.5 milestone Mar 1, 2023
@edbeeching edbeeching modified the milestones: 0.5, 0.6 May 15, 2023
@Ivan-267
Copy link
Collaborator

Ivan-267 commented Dec 3, 2023

This is currently in progress: edbeeching/godot_rl_agents_examples#14 (comment)

This should fix the sensor for Godot 4.2 so it works during training.

What will still be left is to look into:

  • Onnx export / inference support (I didn't yet test whether this works)
  • Add downsampling option for rendered images before sending as obs
  • Potential grayscale feature (reduce the size where colors are not necessary)
  • Maybe having an option to add depth information as the 4th channel

As well as any other features that might be useful.

@edbeeching
Copy link
Owner Author

Hey @Ivan-267 are any items left to do on this?

@Ivan-267
Copy link
Collaborator

Ivan-267 commented Feb 13, 2024

Those were just some proposed options, none are implemented yet. I've tried the sensor a bit after writing those and I can confirm that we can't export onnx / run inference right now.

Edit: I added the idea about downsampling from discord here as well. The list is sorted by importance, to fully support the sensor we need onnx export, other enhancements are optional.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants