Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should logging differentiate 200 from 201 statuses? Are 204 taken into account? #39

Closed
rlittle08 opened this issue Jul 10, 2024 · 2 comments

Comments

@rlittle08
Copy link

As we're working on surfacing lightbeam logs in tables, we realized it is unclear whether records were 200 vs. 201. This is important tracking info - if 200, we should display as such, so analysts/DEs/TDLs understand that the records were found to be "not new".

Similarly, it's unclear to me how/whether 204 status codes are handled in the logging

@tomreitz
Copy link
Collaborator

Currently all of these 2xx statuses are treated as "success." The CLI output shows counts by status code, but I believe the structured logs don't split them out. We could change that behavior if needed? Maybe you can propose a revision to the structure of the --results-file format to include explicit counts by status?

@tomreitz
Copy link
Collaborator

Closing this issue, as it was implemented in the above-mentioned PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants