Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enabling multithreading #15

Closed
katasanirohith opened this issue Jan 5, 2021 · 2 comments
Closed

Enabling multithreading #15

katasanirohith opened this issue Jan 5, 2021 · 2 comments
Assignees
Labels
enhancement New feature or request

Comments

@katasanirohith
Copy link

I have seen that padel descriptor allows multi processing(link). Can we do this in wrapper? because I can see my CPUs are not being used to fullest extent. But, while using GUI from PaDEL usage of CPUs is maximum.

@tjkessler
Copy link
Member

Hi @katasanirohith,

I believe that multiprocessing is already available for use in PaDELPy. As PaDEL's command line interface is leveraged for all functions of the package, the following command line arguments were used:

image

The "-threads" argument, when set to -1, uses the maximum number of threads available on the host machine. In PaDELPy, this value is set to -1 by default:

https://github.com/ECRL/PaDELPy/blob/fd09a3c29786b8374a43409951bb06bc3395d98e/padelpy/wrapper.py#L49

The "from_smiles" function, https://github.com/ECRL/PaDELPy/blob/fd09a3c29786b8374a43409951bb06bc3395d98e/padelpy/functions.py#L23 currently does not support multiple SMILES strings, and will not leverage multiprocessing/multithreading. I'm going to work on implementing support for supplying this function with multiple SMILES strings (i.e. a list of strings), which would allow PaDELPy to leverage multiprocessing/multithreading.

@tjkessler tjkessler self-assigned this Jan 8, 2021
@tjkessler tjkessler added the enhancement New feature or request label Jan 8, 2021
@tjkessler tjkessler mentioned this issue Jan 8, 2021
@tjkessler
Copy link
Member

@katasanirohith,

This issue should be fixed with pull request #16. I'm going to close this issue, but feel free to open it again or submit a new one if you experience any issues!

Best,
Travis

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants