Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SSR broken when Navigator object is defined. Node JS 21. #1046

Closed
sannajammeh opened this issue Dec 13, 2023 · 0 comments · Fixed by #1037
Closed

SSR broken when Navigator object is defined. Node JS 21. #1046

sannajammeh opened this issue Dec 13, 2023 · 0 comments · Fixed by #1037

Comments

@sannajammeh
Copy link

sannajammeh commented Dec 13, 2023 •
edited
Loading

Some environments have Navigator as an empty object even on the server.

Node JS v21 has navigator defined as an empty object.

This causes libraries like echarts to be incompatible with ssr and crash.

The problem is line 35 in zrender/lib/core/env.js

else if (typeof navigator === 'undefined')

Should ideally be:

else if (typeof window === 'undefined')
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(env): fix env detection compatibility for node, bun, and deno Uzlopak/zrender
2 participants
@plainheart @sannajammeh