Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

github action: lint code and run tests #26

Closed
flycash opened this issue Sep 25, 2021 · 1 comment · Fixed by #35
Closed

github action: lint code and run tests #26

flycash opened this issue Sep 25, 2021 · 1 comment · Fixed by #35
Assignees
Labels

Comments

@flycash
Copy link
Contributor

flycash commented Sep 25, 2021

English Only

Please check existing issues first to avoid duplication and answer the questions below before submitting your issue.

Use case(s)

We need a github action to force developers linting code and running tests before push instead of pre-commit.

And you could add more checkpoint if think it's neccessary.
(Please state use cases, what problem will this feature solve?)

Proposed Solution

(Please describe your proposed design/solution, if any)

Alternatives Considered

(Other possible options for solving the problem?)

Additional Context

(Paste any relevant logs - please use code blocks (```) to format console output,
logs, and code as it's very hard to read otherwise.)

(If you can, link to the line of code that might be helpful to explain the context)

@Codexiaoyi
Copy link
Collaborator

Codexiaoyi commented Sep 30, 2021

#35 run test and lint code

@flycash flycash linked a pull request Oct 22, 2021 that will close this issue
@flycash flycash closed this as completed Oct 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants