We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
The SemanticTokensService implementation does not correctly implement the LSP specification in two points.
private int getTokenType(final String[] ids) { for (String id : ids) { Integer index = tokenTypes.indexOf(id); if (index != -1) { return index + 1; } } return 0; } ... Integer positionTokenType = getTokenType(lightweightPosition.getIds()); Integer positionTokenModifiers = getTokenModifiers(lightweightPosition.getIds()); if (positionTokenType != 0 || positionTokenModifiers != 0) { int deltaOffset = lightweightPosition.getOffset() - lastOffset; ...
The specification says: Token types are looked up by index, so a tokenType value of 1 means tokenTypes[1]. https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_semanticTokens
I will open a PR to fix these issues, but I wanted to address them as a problem first.
The text was updated successfully, but these errors were encountered:
No branches or pull requests
The SemanticTokensService implementation does not correctly implement the LSP specification in two points.
The specification says:
Token types are looked up by index, so a tokenType value of 1 means tokenTypes[1].
https://microsoft.github.io/language-server-protocol/specifications/lsp/3.17/specification/#textDocument_semanticTokens
I will open a PR to fix these issues, but I wanted to address them as a problem first.
The text was updated successfully, but these errors were encountered: