Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/svmcomponentids - do not copy svm component ids #1580

Merged
merged 1 commit into from
Sep 30, 2022
Merged

fix/svmcomponentids - do not copy svm component ids #1580

merged 1 commit into from
Sep 30, 2022

Conversation

nikkuma7
Copy link
Contributor

@nikkuma7 nikkuma7 commented Jul 1, 2022 •
edited
Loading

Please provide a summary of your changes here.

Issue:
Do not copy any SVM component ids #1587

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

1)Goto component tab
2)click on component name
3)select release overview
4)We will find the list of name, then click on version
5)click on edit Release button
6)Add external ids and values, then update Release button
7) then go back and click on duplicate.
8) few fields will be editable in new page(duplicate page) ex : edit version
9) click on create release button and verify external ids will be blank.

image

How should these changes be tested by the reviewer?
Have you implemented any additional tests?

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@smrutis1
Copy link
Contributor

smrutis1 commented Jul 6, 2022 •
edited
Loading

@nikkuma7

  1. Create the issue in github issue space and refer the same in description.
  2. Please refer the semantic commit message types and update accordingly.
fix (bug fix for the user, not a fix to a build script)
docs (changes to the documentation)
style (formatting, missing semi colons, etc; no production code change)
refactor (refactoring production code, eg. renaming a variable)
test (adding missing tests, refactoring tests; no production code change)
chore (updating grunt tasks etc; no production code change)

@smrutis1 smrutis1 added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jul 6, 2022
@smrutis1
Copy link
Contributor

smrutis1 commented Jul 6, 2022

(from discussion):
SW360 must not copy the external Id with specific key, while cloning a release.

@ag4ums ag4ums requested a review from smrutis1 July 20, 2022 08:00
smrutis1
smrutis1 requested changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make the property value blank and set the logic accordingly

frontend/sw360-portlet/src/main/resources/sw360.properties Outdated
@@ -91,6 +91,7 @@
#key.auth.givenname=GIVENNAME
#key.auth.surname=SURNAME
#key.auth.department=DEPARTMENT
externalId.remove.while.cloning.release=com.siemens.svm.component.id
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please remove this siemens specific key in the properties file.

@rudra-superrr
Copy link
Contributor

Testing was successful.

@nikkuma7 nikkuma7 force-pushed the fix/SVMComponentIds branch from 821458b to c3b866c Compare August 16, 2022 10:30
@smrutis1
Copy link
Contributor

@nikkuma7 Please squash the commits

smrutis1
smrutis1 requested changes Aug 24, 2022
View reviewed changes
frontend/sw360-portlet/src/main/java/org/eclipse/sw360/portal/common/PortletUtils.java Outdated
CommonUtils.loadProperties(PortletUtils.class, PROPERTIES_FILE_PATH);
Properties props = CommonUtils.loadProperties(PortletUtils.class, PROPERTIES_FILE_PATH);

EXTERNALID_BLOCKLIST_CLONING_RELEASE = props.getProperty("externalId.remove.while.cloning.release", "");
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May be rename it to release.externalId.to.be.removed.while.cloning for better readability.

frontend/sw360-portlet/src/main/java/org/eclipse/sw360/portal/common/PortletUtils.java Show resolved Hide resolved
@nikkuma7 nikkuma7 force-pushed the fix/SVMComponentIds branch 2 times, most recently from 628fe6d to c52d330 Compare September 5, 2022 07:37
@smrutis1
Copy link
Contributor

smrutis1 commented Sep 6, 2022

Please amend the commit message.

image

@nikkuma7 nikkuma7 force-pushed the fix/SVMComponentIds branch from c52d330 to 0cc2f07 Compare September 6, 2022 11:31
@nikkuma7
Copy link
Contributor Author

nikkuma7 commented Sep 6, 2022

Issue is resolve successfully.

@nikkuma7
Copy link
Contributor Author

nikkuma7 commented Sep 6, 2022

image

fix(UI): Do not copy specific external id while cloning release
2db4244 
Signed-off-by: Nikesh kumar <kumar.nikesh@simens.com>
@nikkuma7 nikkuma7 force-pushed the fix/SVMComponentIds branch from 0cc2f07 to 2db4244 Compare September 6, 2022 12:15
smrutis1
smrutis1 approved these changes Sep 22, 2022
View reviewed changes
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks ok

smrutis1
smrutis1 approved these changes Sep 28, 2022
View reviewed changes
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good

@smrutis1 smrutis1 added ready ready to merge and removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Sep 28, 2022
@ag4ums ag4ums merged commit 7b8729d into eclipse-sw360:main Sep 30, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@smrutis1 smrutis1 smrutis1 approved these changes

Assignees
No one assigned
Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@nikkuma7 @smrutis1 @rudra-superrr @ag4ums