Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui) : select your group in Project page by grid #1575

Merged
merged 1 commit into from
Aug 17, 2022

Conversation

KoukiHama
Copy link
Member

@KoukiHama KoukiHama commented Jun 28, 2022

Please provide a summary of your changes here.

  • Which issue is this pull request belonging to and how is it solving it? (Refer to issue here)
  • Did you add or update any new dependencies that are required for your change?

Issue: #1547 #831

From Project Edit page,

image

You can select your group or edit your group as previous.

image

Suggest Reviewer

You can suggest reviewers here with an @mention.

How To Test?

Select your group or Edit your group name.

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

@KoukiHama KoukiHama self-assigned this Jun 28, 2022
@KoukiHama KoukiHama changed the title feature(ui) : select your group in Project page by grid feat(ui) : select your group in Project page by grid Jun 28, 2022
@KoukiHama KoukiHama added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jun 28, 2022
@KoukiHama KoukiHama removed their assignment Jun 29, 2022
@rudra-superrr
Copy link
Contributor

Issues I found while testing:

  • While creating a new project, if we are changing the department from primary to secondary then it not working and taking the primary department by default.
    The same functionality is working if we are updating the existing project i.e. we are able to change the department from primary to secondary.
  • If we are entering any random text in Enter Group name field then its taking that random name for the group/department.

department

depart2

@KoukiHama
Copy link
Member Author

KoukiHama commented Jul 5, 2022

Thank for doing test and report the issue.

While creating a new project, if we are changing the department from primary to secondary then it not working and taking the primary department by default.
The same functionality is working if we are updating the existing project i.e. we are able to change the department from primary to secondary.

I will check 1st one. But I think primarily or secondary info is not related to Group setting.
Because, on latest sw360, we can set the group name freely.

If we are entering any random text in Enter Group name field then its taking that random name for the group/department.

About 2nd one, user can enter random name for project on latest sw360 too.
Should we remove the function to enter project name which is not related user group?

I made issue about this #1581

@KoukiHama KoukiHama added question Further information is requested in progress and removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Jul 5, 2022
@rudra-superrr
Copy link
Contributor

Either we should remove the enter group name field or the entered text should be compared to all the departments in order to make sure its a valid department/group.

@KoukiHama
Copy link
Member Author

@rudra-superrr

Thank you comment.

Either we should remove the enter group name field or the entered text should be compared to all the departments in order to make sure its a valid department/group.

OK. so do we need to fix this issue? #1581
Now sw360 users can enter invalid department on latest sw360 version 896a912 too.

It is good, but, maybe, we should make other pull request for fix #1581.

@KoukiHama
Copy link
Member Author

KoukiHama commented Jul 6, 2022

After fix #1581. We can remove " enter group name field" in the PR.

@KoukiHama
Copy link
Member Author

this is related to #1321

@KoukiHama
Copy link
Member Author

KoukiHama commented Jul 6, 2022

@rudra-superrr

While creating a new project, if we are changing the department from primary to secondary then it not working and taking the primary department by default.

About your this comment, it has already reported. #831
This is not my PR issue, but I will fix it too before merge this #1575.

@rudra-superrr
Copy link
Contributor

Thanks @KoukiHama for looking into this.

@KoukiHama KoukiHama removed the question Further information is requested label Jul 13, 2022
@KoukiHama KoukiHama closed this Jul 21, 2022
@KoukiHama KoukiHama force-pushed the department-search branch from e45905d to 4678016 Compare July 21, 2022 06:33
@KoukiHama KoukiHama reopened this Jul 21, 2022
@KoukiHama KoukiHama self-assigned this Jul 21, 2022
@KoukiHama
Copy link
Member Author

KoukiHama commented Jul 21, 2022

In order to preserve this change #1321, users can continue to change department name freely.
On the other hand, I fixed #831 too in this pull request.

@rudra-superrr could you check 0fe8e43 again?

@KoukiHama KoukiHama added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for and removed in progress labels Jul 21, 2022
@nikkuma7
Copy link
Contributor

Testing successful

@ag4ums ag4ums removed the needs general test This is general testing, meaning that there is no org specific issue to check for label Aug 11, 2022
@ag4ums ag4ums requested a review from smrutis1 August 11, 2022 08:39
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please check one minor review comment

@KoukiHama KoukiHama requested a review from smrutis1 August 17, 2022 06:43
Copy link
Contributor

@smrutis1 smrutis1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good.

@smrutis1 smrutis1 added ready ready to merge and removed needs code review labels Aug 17, 2022
@ag4ums ag4ums merged commit 9b8d5cc into eclipse-sw360:main Aug 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ready ready to merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

User should also be able to select Group for Project/Component by Grid from your Group
5 participants