Fixes #6072 - jetty server high CPU when client sends TLS record length > 17408 (jetty-10.0.x) #6074
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…408. Avoid spinning if the input buffer is full. Signed-off-by: Simone Bordet <simone.bordet@gmail.com> Co-authored-by: Joakim Erdfelt <joakim.erdfelt@gmail.com>
|
Forward port of #6073 |
joakime
changed the title
joakime
changed the title
joakime
changed the title
gregw
approved these changes
Mar 19, 2021
gregw
requested changes
Mar 22, 2021
jetty-io/src/main/java/org/eclipse/jetty/io/ssl/SslConnection.java
Outdated
Show resolved
Hide resolved
…408. Updates after review. Signed-off-by: Simone Bordet <simone.bordet@gmail.com>
gregw
approved these changes
Mar 22, 2021
lorban
reviewed
Mar 22, 2021
|
|
||
| // Sleep to see if the server spins. | ||
| Thread.sleep(1000); | ||
| assertThat(unwraps.get(), lessThan(128L)); |
There was a problem hiding this comment.
I would move the assertion out of the try-with-resource block as the IO.readBytes call already would wait 1s if this bug is triggered.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…408.
Avoid spinning if the input buffer is full.
Signed-off-by: Simone Bordet simone.bordet@gmail.com
Co-authored-by: Joakim Erdfelt joakim.erdfelt@gmail.com