Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change default machine name to che #972

Merged
merged 3 commits into from
Apr 8, 2016
Merged

Change default machine name to che #972

merged 3 commits into from
Apr 8, 2016

Conversation

TylerJewell
Copy link

Improved an error message and changed the default docker-machine to be named "che". This solves some issues with Windows systems that have previously run a docker machine named "default".

@TylerJewell
Copy link
Author

@eivantsov, @riuvshin - wdyt.

@vparfonov
Copy link
Contributor

ok

@riuvshin
Copy link
Contributor

riuvshin commented Apr 6, 2016

OK if you've tested this, because we don't have windows to test

@TylerJewell
Copy link
Author

QA needs windows environments to test.

@riuvshin
Copy link
Contributor

riuvshin commented Apr 7, 2016

OK

@vparfonov
Copy link
Contributor

Tested on my machine Windows 10.
$ docker --version
Docker version 1.9.1, build a34a1d5
Can confirm working well.
After stopping Che Workspace Master VM Che not removed and after start again images don't pulling again.

But met problem with starting Workspace Agent not enough time
machine.ws_agent.max_start_time_ms=60000 propose increase this value 4-5 times.

@TylerJewell TylerJewell merged commit 9e4e3c4 into master Apr 8, 2016
@TylerJewell TylerJewell deleted the CHE-935 branch April 8, 2016 03:20
@ghost
Copy link

ghost commented Apr 8, 2016

worked for me

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants