CHE-98: Restyle check-boxes position in 'git commit' view #971
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@vinokurig - it looks like the check boxes are not vertically spaced properly? |
|
I have separated with space 'Amend previous commit' check-box because this operation differs from those that are above, @TylerJewell what do you think? |
|
@vinokurig - thank you for the explanation. If you hadn't said that, i would have not understood it. I think to the average user, it will look weird, though. It would need to be separated by a separator to make it clear that we mean something different. I think it's safer to keep it all evenly spaced only because it is not so intuitive. |
|
|
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@vparfonov please review