CHE-718: Simplify workspace model & API #954
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM |
|
Code looks much better in many places. Nice job! |
|
ok |
| BadRequestException { | ||
| public WorkspaceDto getByKey(@ApiParam(value = "Composite key", | ||
| examples = @Example({@ExampleProperty("workspace12345678"), | ||
| @ExampleProperty("username:workspace_name"), |
There was a problem hiding this comment.
It is not clear what is username for workspace. Maybe you should rewrite this with namespace?
voievodin
force-pushed
the
CHE-718-2
branch
3 times, most recently
from
2538b57 to
76df556
Compare
|
ci-build |
|
ok |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Model changes:
Removed -
UsersWorkspace,RuntimeWorkspaceAdded -
Workspace,WorkspaceRuntimeMoved attributes from
WorkspaceConfigtoWorkspaceAPI & SPI changes
Simplified API by removing methods related to the runtime workspace instance.
Improved workspace sub-entity update methods.
Added
createdandupdatedattributes which allow client to track recent workspace activity.Improved Workspace starting and stopping by synchronizing machines start queue.
Simplified
WorkspaceManager, events moved to theWorkspaceRuntimes.BadRequestException scope changed to service.
@gazarenkov, @garagatyi, @skabashnyuk, @akorneta please review changes described above.
Dashboard Adaptation
@ashumilova, @benoitf please review the changes related to the dashboard.