Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CHE-708: Add CORS Filter #767

Merged
merged 1 commit into from
Mar 24, 2016
Merged

CHE-708: Add CORS Filter #767

merged 1 commit into from
Mar 24, 2016

Conversation

dimashnurenko
Copy link

  1. MachineExtensionProxyServlet removed.
  2. Add CORS filter to filter requests. More information about filter [https://developer.mozilla.org/en-US/docs/Web/HTTP/Access_control_CORS]
  3. WsAgentUrlProvider provides URL to send requests to workspace agent directly.

@vparfonov @skabashnyuk @garagatyi

@@ -275,11 +275,6 @@
<scope>provided</scope>
</dependency>
<dependency>
<groupId>org.apache.tomcat</groupId>

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@vparfonov @skabashnyuk Is it OK to remove provided dependency here?

@vparfonov
Copy link
Contributor

ok

@dimashnurenko dimashnurenko merged commit aa105b9 into master Mar 24, 2016
@dimashnurenko dimashnurenko deleted the CHE-708 branch March 24, 2016 08:23
@benoitf
Copy link
Contributor

benoitf commented Mar 24, 2016

I don't see any dashboard changes in this PR, like I expect a big failure to all /ext/ calls

@dimashnurenko dimashnurenko restored the CHE-708 branch March 24, 2016 11:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants