CHE-260 Rename some factory parameters #764
Conversation
|
what about existing factories? will they work as expected? |
|
AFAIK we are going to provide mongo script for this cas? |
|
for codenvy mongo script is OK, but Che users may have serialized workspaces. Will this PR broke these workspaces? |
|
Mongo script is added to Codenvy issue. |
|
What is the documentation that needs to be updated on docs.codenvy.com or eclipse.org/che? The GitHub PR needs to have a complete set of documents for the history so that future readers of this issue can understand what is being changed and the impact to their system. |
| @@ -127,12 +127,12 @@ public void keepDirectorySelected(boolean keepDirectory) { | |||
| view.enableDirectoryNameField(keepDirectory); | |||
|
|
|||
| if (keepDirectory) { | |||
| projectParameters().put("keepDirectory", view.getDirectoryName()); | |||
| projectParameters().put("keepDir", view.getDirectoryName()); | |||
There was a problem hiding this comment.
You forgot to adapt GithubImporterPagePresenter, be carefully about that.
mkuznyetsov
force-pushed
the
rename-parameters
branch
4 times, most recently
from
8442fbf to
25e3342
Compare
mkuznyetsov
force-pushed
the
rename-parameters
branch
from
25e3342 to
56da67f
Compare
Rename the following project source parameters:
"project.source.parameters.keepDirectory" to "project.source.parameters.keepDir".
"project.source.parameters.remoteOriginFetch" to "project.source.parameters.fetch"
The old parameter names are not going to work anymore, so all existing workspaces with such projects should be updated